Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move "Cleanup Database" functionality to new artisan command #2580

Merged
merged 7 commits into from
Nov 25, 2024
Merged

Move "Cleanup Database" functionality to new artisan command #2580

merged 7 commits into from
Nov 25, 2024

Conversation

zackgalbreath
Copy link
Contributor

No description provided.

@zackgalbreath
Remove unnecessary deletes from "Cleanup Database"
ca4e645 
These tables now get cleaned up automatically by foreign key constraints.
@zackgalbreath zackgalbreath force-pushed the cleanup_database_artisan branch from 9cc50d3 to a362e63 Compare November 21, 2024 17:19
williamjallen
williamjallen requested changes Nov 22, 2024
View reviewed changes
app/Console/Commands/DeepCleanDatabase.php Outdated Show resolved Hide resolved
app/Console/Commands/DeepCleanDatabase.php Outdated Show resolved Hide resolved
app/Utils/DatabaseCleanupUtils.php Outdated Show resolved Hide resolved
@zackgalbreath zackgalbreath force-pushed the cleanup_database_artisan branch from fda4390 to 7b03292 Compare November 22, 2024 13:48
williamjallen
williamjallen reviewed Nov 22, 2024
View reviewed changes
Copy link
Collaborator

@williamjallen williamjallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A basic test for the new script would probably be useful, but I wouldn't have a problem merging this and adding a test in a follow-up PR if you want to expedite this for any reason.

@zackgalbreath
Restore test_removebuilds
8dcad07 
Half of this test was accidentally disabled in #964
@zackgalbreath
Verify deletion of shared resources in test_removebuilds
eeefa59 
Also cleanup various PHPStan warnings in test_removebuilds.php
@zackgalbreath zackgalbreath force-pushed the cleanup_database_artisan branch from 48e1651 to eeefa59 Compare November 22, 2024 22:04
@williamjallen williamjallen added this to the v3.7 milestone Nov 25, 2024
@zackgalbreath zackgalbreath added this pull request to the merge queue Nov 25, 2024
Merged via the queue into master with commit 62feae3 Nov 25, 2024
6 checks passed
@zackgalbreath zackgalbreath deleted the cleanup_database_artisan branch November 25, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williamjallen williamjallen williamjallen approved these changes

Assignees
No one assigned
Labels
release notes: administration
Projects
None yet
Milestone
v3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@zackgalbreath @williamjallen